use spl-governance serializers #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
setting GENERATE_SOURCEMAP=false due to facebook/create-react-app#11752 also using react-app-rewired due to facebook/create-react-app#12021 and solana-labs/oyster#538
| "build": "react-scripts build", | ||
| "test": "react-scripts test", | ||
| "eject": "react-scripts eject" | ||
| "start": "GENERATE_SOURCEMAP=false react-app-rewired start", |
There was a problem hiding this comment.
There was a comment somewhere that says this is not super nice because you kind of like to have sourcemap later in dev mode. Later we can do another fix for that. I think it's just a "avoid sending errors/warning from this file/folder" i think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To move faster, let's just use
spl-governanceserializers under the hood.See commits for details