Fix poetry install issue on platform.sh. #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`poetry install` raised: `AttributeError: 'Link' object has no attribute 'is_absolute'` during build on platform.sh. It appears that it's possible for poetry-core to update even if poetry is locked. Our issue wasa caused by a regression introduced in 1.0.4. Updated poetry following the advice in the linked github issue and updated pip to fix an issue selecting the correct wheel for cryptography `36.0.0` on platform.sh. Locked Poetry to `1.1.12` and pip to `21.3.1` for docker and platform.sh Related issues: - [Link object being passed instead of Path to poetry.core.packages.file_dependency.FileDependency in poetry-core 1.0.5](python-poetry/poetry#4541) - [fix: Broken cache on Windows #4531](python-poetry/poetry#4531)
ababic
approved these changes
Jan 10, 2022
There was a problem hiding this comment.
@danbentley Good work! The container is rebuilding fine for me locally with these changes, which I guess is the main concern, so I would say go ahead and merge :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
poetry installraised:AttributeError: 'Link' object has no attribute 'is_absolute'during build on platform.sh.It appears that it's possible for poetry-core to update even if poetry is locked. Our issue was a caused by a regression introduced in 1.0.4.
Updated poetry following the advice in the linked github issue and updated pip to fix an issue selecting the correct wheel for cryptography
36.0.0on platform.sh.Locked Poetry to
1.1.12and pip to21.3.1for docker and platform.sh