Refactoring

Add PHP 8.1 readonly properties where relevant
natitech · Jul 6, 2023 · bf644cc · bf644cc
1 parent 25f958b
commit bf644cc
Show file tree

Hide file tree

Showing 9 changed files with 14 additions and 14 deletions.
diff --git a/src/BusinessCalendar.php b/src/BusinessCalendar.php
@@ -6,7 +6,7 @@
 
 final class BusinessCalendar
 {
-    private HolidaysCalendar $holidaysCalendar;
+    private readonly HolidaysCalendar $holidaysCalendar;
 
     /** @var \Nati\Businesscal\Holidays\Holiday[][] */
     private array              $holidays = [];

diff --git a/src/Holidays/Calendar/CHNationalHolidaysCalendar.php b/src/Holidays/Calendar/CHNationalHolidaysCalendar.php
@@ -8,7 +8,7 @@
 
 final class CHNationalHolidaysCalendar implements HolidaysCalendar
 {
-    private ChristianCalendar $christian;
+    private readonly ChristianCalendar $christian;
 
     public function __construct()
     {

diff --git a/src/Holidays/Calendar/FRHolidaysCalendar.php b/src/Holidays/Calendar/FRHolidaysCalendar.php
@@ -8,7 +8,7 @@
 
 final class FRHolidaysCalendar implements HolidaysCalendar
 {
-    private ChristianCalendar $christian;
+    private readonly ChristianCalendar $christian;
 
     public function __construct()
     {

diff --git a/src/Holidays/Calendar/HolidayApiCalendar.php b/src/Holidays/Calendar/HolidayApiCalendar.php
@@ -8,7 +8,7 @@
 
 final class HolidayApiCalendar implements HolidaysCalendar
 {
-    private Client  $api;
+    private readonly Client  $api;
 
     private array   $holidays;
 

diff --git a/src/Holidays/Calendar/PFHolidaysCalendar.php b/src/Holidays/Calendar/PFHolidaysCalendar.php
@@ -11,9 +11,9 @@
  */
 final class PFHolidaysCalendar implements HolidaysCalendar
 {
-    private FRHolidaysCalendar $fr;
+    private readonly FRHolidaysCalendar $fr;
 
-    private ChristianCalendar $christian;
+    private readonly ChristianCalendar $christian;
 
     public function __construct()
     {

diff --git a/src/Holidays/Calendar/SolidarityFRHolidaysCalendar.php b/src/Holidays/Calendar/SolidarityFRHolidaysCalendar.php
@@ -11,9 +11,9 @@
  */
 final class SolidarityFRHolidaysCalendar implements HolidaysCalendar
 {
-    private FRHolidaysCalendar $fr;
+    private readonly FRHolidaysCalendar $fr;
 
-    private ChristianCalendar $christian;
+    private readonly ChristianCalendar $christian;
 
     public function __construct()
     {

diff --git a/src/Holidays/Holiday.php b/src/Holidays/Holiday.php
@@ -6,9 +6,9 @@
 
 final class Holiday
 {
-    public \DateTimeImmutable $date;
+    public readonly \DateTimeImmutable $date;
 
-    public ?string            $label;
+    public readonly ?string            $label;
 
     public static function create(\DateTimeImmutable $date, $label = null): self
     {

diff --git a/test/Unit/BusinessCalendarTest.php b/test/Unit/BusinessCalendarTest.php
@@ -10,9 +10,9 @@
 
 class BusinessCalendarTest extends TestCase
 {
-    private HolidaysCalendarMock $holidays;
+    private readonly HolidaysCalendarMock $holidays;
 
-    private BusinessCalendar     $adder;
+    private readonly BusinessCalendar     $adder;
 
     protected function setUp(): void
     {

diff --git a/test/Unit/Holidays/Calendar/HolidayApiCalendarTest.php b/test/Unit/Holidays/Calendar/HolidayApiCalendarTest.php
@@ -10,9 +10,9 @@
 
 class HolidayApiCalendarTest extends TestCase
 {
-    private HolidayApiCalendar $calendar;
+    private readonly HolidayApiCalendar $calendar;
 
-    private HolidayApiWrapperMock $api;
+    private readonly HolidayApiWrapperMock $api;
 
     protected function setUp(): void
     {