Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignore pointer size tests #120

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

ignore pointer size tests #120

wants to merge 2 commits into from

Conversation

phi-gamma
Copy link

Fixes #119

@phi-gamma
ignore pointer size tests
c1db53b 
As of JVM 12 and later it is no longer possible to cast away the
``final`` modifier using reflection so the ``forece{32,64}Bit``
helpers error out with an exception:

    Tests run: 34, Failures: 0, Errors: 2, Skipped: 1, Time elapsed: 0.052 sec <<< FAILURE! - in org.bridj.DemanglingTest
    testIntVsPointer_32bits(org.bridj.DemanglingTest)  Time elapsed: 0.006 sec  <<< ERROR!
    java.lang.RuntimeException: java.lang.NoSuchFieldException: modifiers
        at java.base/java.lang.Class.getDeclaredField(Class.java:2610)
        at org.bridj.util.ReflectionUtils.makeFieldWritable(ReflectionUtils.java:42)
        at org.bridj.util.PlatformTestUtils.forcePointerSize(PlatformTestUtils.java:22)
        at org.bridj.util.PlatformTestUtils.force32Bits(PlatformTestUtils.java:30)
        at org.bridj.DemanglingTest.testIntVsPointer_32bits(DemanglingTest.java:553)

    testIntVsPointer_64bits(org.bridj.DemanglingTest)  Time elapsed: 0.001 sec  <<< ERROR!
    java.lang.RuntimeException: java.lang.NoSuchFieldException: modifiers
        at java.base/java.lang.Class.getDeclaredField(Class.java:2610)
        at org.bridj.util.ReflectionUtils.makeFieldWritable(ReflectionUtils.java:42)
        at org.bridj.util.PlatformTestUtils.forcePointerSize(PlatformTestUtils.java:22)
        at org.bridj.util.PlatformTestUtils.force64Bits(PlatformTestUtils.java:33)
        at org.bridj.DemanglingTest.testIntVsPointer_64bits(DemanglingTest.java:566)

Disable those tests until the functionality can be restored.

References:

    - https://bugs.openjdk.java.net/browse/JDK-8210522
    - https://stackoverflow.com/a/56043252/7321177

Signed-off-by: Philipp Gesang <philipp.gesang@vernaio.com>
@phi-gamma
fix platform detection logic on MacOS
56ef3dc 
This was tested on an M1 MacBook; it reports the machine type as
``arm64``, not ``aarch64``. The full ``uname -a`` output is:

    Darwin <NAME-REDACTED>-MBP14.local 22.2.0 Darwin Kernel Version 22.2.0: Fri Nov 11 02:03:51 PST 2022; root:xnu-8792.61.2~4/RELEASE_ARM64_T6000 arm64

This diverges from what ``System.getProperty("os.arch")`` reports
as the architecture.

Signed-off-by: Philipp Gesang <philipp.gesang@vernaio.com>
@phi-gamma phi-gamma mentioned this pull request Feb 10, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test failures on Linux AMD64
1 participant
@phi-gamma