-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lib/j_unit.rb to be able to omit the require 'yarjuf' statements #6
base: master
Are you sure you want to change the base?
Conversation
…quiring yarjuf gem and keep a simple pointer in lib/yarjuf.rb.
@dpree Could you change the tests so they pass? At the moment they all fail... |
@natritmeyer sorry, wasn't aware of the ./features directory. with my latest fix all tests pass (cucumber + rspec) at least for me. can u confirm? |
@dpree the tests are still requiring the yarjuf gem before rspec has loaded. See here for an example: Line 17 in ad39fff
As it stands, the tests are executing the following: ...but in order to test yarjuf without loading it before rspec (the purpose of your pull request - and an awesome change it would be!) the tests need to be executing the following: However, having tried the code in this pull request without "-r ../../lib/yarjuf" and also having added a
|
Without this I had to do
rspec -r yarjuf -f JUnit
orbundle exec rspec -f JUnit
to load yarjuf before rspec was loaded. Otherwiese (e.g. puttingrequire 'yarjuf'
in a spec_helper.rb) errors like this were raised:After the change I made you can just do
rspec -f JUnit
without doing any pre-require statements.