Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retract case-insensitive tag functionality #233

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Retract case-insensitive tag functionality #233

merged 2 commits into from
Oct 9, 2024

Conversation

aricart
Copy link
Member

@aricart aricart commented Oct 9, 2024

This PR reverts #225, and retracts v2.7.0/v2.7.1

@aricart
Revert "[CHANGE] Tags are now case-sensitive (#225)"
dddda88 
This reverts commit de1f16b.
@aricart
retract 2.7.0
64888e9 
Signed-off-by: Alberto Ricart <alberto@synadia.com>
@aricart aricart requested a review from ripienaar October 9, 2024 15:54
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11258600201

Details

  • 15 of 17 (88.24%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 81.111%
Changes Missing Coverage Covered Lines Changed/Added Lines %
v2/types.go 15 17 88.24%
Files with Coverage Reduction New Missed Lines %
v2/types.go 2 87.97%
Totals Coverage Status
Change from base Build 10906299209: 0.1%
Covered Lines: 2744
Relevant Lines: 3383
💛 - Coveralls

@aricart aricart changed the title Retract 2.7.0 functionality Retract case-insensitive tag functionality Oct 9, 2024
neilalexander
neilalexander approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aricart aricart merged commit f9c7776 into main Oct 9, 2024
8 checks passed
@aricart aricart deleted the retract2 branch October 9, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neilalexander neilalexander neilalexander approved these changes

@ripienaar ripienaar Awaiting requested review from ripienaar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aricart @coveralls @neilalexander