Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add response type hints to micro responses #183

Merged
merged 1 commit into from
Dec 28, 2022
Merged

Conversation

ripienaar
Copy link
Contributor

This adds type hints in line with those used by JetStream API to micro responses.

The goal is to be able to attach JSON schema (and others) to these for validation, documentation, discovery of design and more.

These schemas will be surfaced in "nats schema" command as well.

Signed-off-by: R.I.Pienaar rip@devco.net

This adds type hints in line with those used by JetStream
API to micro responses.

The goal is to be able to attach JSON schema (and others)
to these for validation, documentation, discovery of design
and more.

These schemas will be surfaced in "nats schema" command
as well.

Signed-off-by: R.I.Pienaar <rip@devco.net>
Copy link
Member

@aricart aricart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

adr/ADR-32.md Show resolved Hide resolved
adr/ADR-32.md Show resolved Hide resolved
adr/ADR-32.md Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants