Can't recover stream on restart with deleted msg error. #2900
Conversation
…th deleted messages. Signed-off-by: Derek Collison <derek@nats.io>
…recovery. Signed-off-by: Derek Collison <derek@nats.io>
| _, err = js.StreamInfo("T") | ||
| require_NoError(t, err) |
There was a problem hiding this comment.
check for 99 messages and that js.GetMsg("T", 22) fails?
Am I right to assume that that upon recovery the missing fss file should exist again?
There was a problem hiding this comment.
We have hundreds of tests that already do this. I understand where you are coming from and actually started to write that and was like, the stream info message count deleted messages have tests everywhere for over a year. So I say no.
There was a problem hiding this comment.
Meaning I do not believe it buys us anything over the current tests that are in place.
There was a problem hiding this comment.
The bug was in rebuilding the fss state. That file does not actually exists during the server running, only on exit as a short cut on restart.
There was a problem hiding this comment.
Also just as an fyi, I always write the test to fail first and it did with "stream not found", which is what was reported, so as long as the fix had the stream being found I think we are good, IMO.
Fixed a bug that would not recover a stream properly after a non-clean shutdown with deleted messages.
Signed-off-by: Derek Collison derek@nats.io
/cc @nats-io/core