Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVED] Avoid loading last blks on LoadNextMsg() miss. #5584

Merged
merged 1 commit into from
Jun 23, 2024
Merged

[IMPROVED] Avoid loading last blks on LoadNextMsg() miss. #5584

merged 1 commit into from
Jun 23, 2024

Conversation

derekcollison
Copy link
Member

Make sure on a miss from a starting sequence that if no other msgs exists we avoid loading and blocks.
Match logic for interior skips.

Signed-off-by: Derek Collison derek@nats.io

@derekcollison
Make sure on a miss from a starting sequence that if no other msgs ex…
cdb62ab 
…ists we avoid loading and blocks.

Signed-off-by: Derek Collison <derek@nats.io>
@derekcollison derekcollison requested a review from a team as a code owner June 22, 2024 21:22
wallyqs
wallyqs approved these changes Jun 23, 2024
View reviewed changes
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

neilalexander
neilalexander approved these changes Jun 23, 2024
View reviewed changes
Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 3a32c41 into main Jun 23, 2024
3 checks passed
@derekcollison derekcollison deleted the loadnext-skiplast branch June 23, 2024 13:11
@wallyqs wallyqs mentioned this pull request Jun 25, 2024
Merged
wallyqs added a commit that referenced this pull request Jun 25, 2024
@wallyqs
Cherry picks for v2.10.17-RC.8 (#5590)
7238011 
Includes:

- #5584
- #5585
- #5586
- #5587
- #5589
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallyqs wallyqs wallyqs approved these changes

@neilalexander neilalexander neilalexander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@derekcollison @wallyqs @neilalexander