Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-picks for 2.10.18-RC.2 #5640

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Cherry-picks for 2.10.18-RC.2 #5640

merged 1 commit into from
Jul 10, 2024
+54 −3

Conversation

wallyqs
Copy link
Member

@wallyqs wallyqs commented Jul 10, 2024

@derekcollison @wallyqs
When checking interest state, make sure to take into account filtered…
4b1f83f 
… consumers when acking msgs.

Signed-off-by: Derek Collison <derek@nats.io>
@wallyqs wallyqs requested a review from a team as a code owner July 10, 2024 22:33
derekcollison
derekcollison approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wallyqs wallyqs merged commit 392149f into release/v2.10.18 Jul 10, 2024
3 checks passed
@wallyqs wallyqs deleted the downstream/v2.10.18 branch July 10, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekcollison derekcollison derekcollison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wallyqs @derekcollison