Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In client and leafnode results cache, populate new entry after pruning #5760

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

neilalexander
Copy link
Member

Otherwise we might add the entry into the cache and then immediately prune it afterwards, depending on luck/map iteration order.

Signed-off-by: Neil Twigg neil@nats.io

Otherwise we might add the entry into the cache and then immediately
prune it afterwards, depending on luck/map iteration order.

Signed-off-by: Neil Twigg <neil@nats.io>
@neilalexander neilalexander requested a review from a team as a code owner August 7, 2024 16:12
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 0a8f982 into main Aug 7, 2024
5 checks passed
@derekcollison derekcollison deleted the neil/inresults branch August 7, 2024 16:48
wallyqs added a commit that referenced this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants