Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows: Search for DLLs in system paths only #5836

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Windows: Search for DLLs in system paths only #5836

merged 1 commit into from
Aug 28, 2024

Conversation

neilalexander
Copy link
Member

@neilalexander neilalexander commented Aug 28, 2024 •
edited
Loading

Otherwise DLLs can potentially be loaded in from the current working directory.

Tested on a Windows 11 ARM64 virtual machine.

Reported-by: Trail of Bits https://www.trailofbits.com
Signed-off-by: Neil Twigg neil@nats.io

@neilalexander
Windows: Search for DLLs in system paths only
0a02d82 
Reported-by: Trail of Bits <https://www.trailofbits.com>
Signed-off-by: Neil Twigg <neil@nats.io>
@neilalexander neilalexander marked this pull request as ready for review August 28, 2024 09:46
@neilalexander neilalexander requested a review from a team as a code owner August 28, 2024 09:46
derekcollison
derekcollison approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit f1f3cdc into main Aug 28, 2024
5 checks passed
@derekcollison derekcollison deleted the neil/windll branch August 28, 2024 15:55
@neilalexander neilalexander mentioned this pull request Aug 29, 2024
Merged
wallyqs added a commit that referenced this pull request Aug 29, 2024
@wallyqs
Cherry picks for v2.10.20 (#5843)
a24fe36 
Includes:

- #5841 
- #5836
- #5837
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekcollison derekcollison derekcollison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neilalexander @derekcollison