-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
De-flake TestNoRaceJetStreamClusterGhostConsumers #5985
De-flake TestNoRaceJetStreamClusterGhostConsumers #5985
Conversation
CI just demonstrated it can still flake after this.. will need to investigate further. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Let me know when you convert off of draft.. |
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
8c61cad
to
06fda16
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made one additional change, both CI jobs now passed first try as well.
Marking ready for review.
@@ -6675,8 +6677,10 @@ func TestNoRaceJetStreamClusterGhostConsumers(t *testing.T) { | |||
time.Sleep(5 * time.Second) | |||
cancel() | |||
|
|||
checkFor(t, 30*time.Second, time.Second, func() error { | |||
m, err := nc.Request("$JS.API.CONSUMER.LIST.TEST", nil, time.Second) | |||
subj := fmt.Sprintf(JSApiConsumerListT, "TEST") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made consistent with TestJetStreamClusterGhostEphemeralsAfterRestart
now as well.
Consumer removal has exponential backoff starting from
startInterval
moving all the way up to max 5 minutes. This lowers that max for these tests.Signed-off-by: Maurice van Veen github@mauricevanveen.com