De-flake TestNoRaceJetStreamClusterGhostConsumers #5985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI just demonstrated it can still flake after this.. will need to investigate further. |
|
Let me know when you convert off of draft.. |
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
MauriceVanVeen
force-pushed
the
maurice/de-flake-js-cluster-ghost-consumers
branch
from
8c61cad
to
06fda16
Compare
MauriceVanVeen
commented
Oct 15, 2024
| @@ -6675,8 +6677,10 @@ func TestNoRaceJetStreamClusterGhostConsumers(t *testing.T) { | |||
| time.Sleep(5 * time.Second) | |||
| cancel() | |||
|
|
|||
| checkFor(t, 30*time.Second, time.Second, func() error { | |||
| m, err := nc.Request("$JS.API.CONSUMER.LIST.TEST", nil, time.Second) | |||
| subj := fmt.Sprintf(JSApiConsumerListT, "TEST") | |||
There was a problem hiding this comment.
Made consistent with TestJetStreamClusterGhostEphemeralsAfterRestart now as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consumer removal has exponential backoff starting from
startIntervalmoving all the way up to max 5 minutes. This lowers that max for these tests.Signed-off-by: Maurice van Veen github@mauricevanveen.com