Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some channels config does not show properly on startup #1106

Closed
kozlovic opened this issue Oct 12, 2020 · 0 comments · Fixed by #1107
Closed

Some channels config does not show properly on startup #1106

kozlovic opened this issue Oct 12, 2020 · 0 comments · Fixed by #1107
Assignees
Labels

Comments

@kozlovic
Copy link
Member

With the following channels configuration:

streaming {
  store_limits: {
    channels {
      bar: {
        max_msgs: 5
      }

      bar.>: {
        max_msgs: 10
      }
    }
  }
}

the channel "bar" is not displayed in the banner, only "bar.>"

[11029] 2020/10/12 17:52:25.907591 [INF] STREAM: -------- List of Channels --------
[11029] 2020/10/12 17:52:25.907593 [INF] STREAM: bar.>
[11029] 2020/10/12 17:52:25.907596 [INF] STREAM:  |-> Messages                   10
[11029] 2020/10/12 17:52:25.907598 [INF] STREAM: ----------------------------------

It appears that the limit is correctly applied for the channel "bar" though. Trying to send 100 messages produce this:

[11029] 2020/10/12 17:53:05.266066 [INF] STREAM: Channel "bar" has been created
[11029] 2020/10/12 17:53:05.266215 [WRN] STREAM: Reached limits for store "bar" (msgs=5/5 bytes=740 B/0 B), dropping old messages to make room for new ones

If the channel "bar.>" is removed, or if "bar" is called "foo", then configuration is properly displayed:

[11384] 2020/10/12 17:55:09.319679 [INF] STREAM: -------- List of Channels --------
[11384] 2020/10/12 17:55:09.319681 [INF] STREAM: foo
[11384] 2020/10/12 17:55:09.319683 [INF] STREAM:  |-> Messages                    5
[11384] 2020/10/12 17:55:09.319686 [INF] STREAM: bar.>
[11384] 2020/10/12 17:55:09.319688 [INF] STREAM:  |-> Messages                   10
[11384] 2020/10/12 17:55:09.319690 [INF] STREAM: ----------------------------------

/cc @wallyqs

@kozlovic kozlovic self-assigned this Oct 12, 2020
@kozlovic kozlovic added the bug label Oct 12, 2020
kozlovic added a commit that referenced this issue Oct 13, 2020
With this fix, the channels bar and bar.> will be properly displayed.
```
[13010] 2020/10/12 18:08:35.531185 [INF] STREAM: -------- List of Channels --------
[13010] 2020/10/12 18:08:35.531188 [INF] STREAM: bar
[13010] 2020/10/12 18:08:35.531193 [INF] STREAM:  |-> Messages                    5
[13010] 2020/10/12 18:08:35.531196 [INF] STREAM: bar.>
[13010] 2020/10/12 18:08:35.531198 [INF] STREAM:  |-> Messages                   10
[13010] 2020/10/12 18:08:35.531200 [INF] STREAM: ----------------------------------
```

Resolves #1106

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant