Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADDED] Reload signal now accepted for the embedded NATS Server #1031

Merged
merged 1 commit into from
Apr 2, 2020

Conversation

kozlovic
Copy link
Member

@kozlovic kozlovic commented Apr 2, 2020

Previously, the reload signal was ignored. It will now be passed
on to the embedded NATS Server. If the streaming server remotely
connects to a NATS Server and a reload signal is received, the
streaming server will print a warning indicating that it works
only for NATS Server configuration and only if it is embedded.

Resolves #1030

Signed-off-by: Ivan Kozlovic ivan@synadia.com

Previously, the reload signal was ignored. It will now be passed
on to the embedded NATS Server. If the streaming server remotely
connects to a NATS Server and a reload signal is received, the
streaming server will print a warning indicating that it works
only for NATS Server configuration and only if it is embedded.

Resolves #1030

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 91.921% when pulling 3dd9176 on fix_1030 into 9c525aa on master.

Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kozlovic kozlovic merged commit 29f2f83 into master Apr 2, 2020
@kozlovic kozlovic deleted the fix_1030 branch April 2, 2020 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--signal reloaddoesn't seem to reload the (embedded) NATS configuration file
3 participants