[IMPROVED] Clustering: Report possible misconfiguration of peers list #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The clustering peers list is supposed to contain the list of peer
node ids. However, it happens that users make the mistake of listing
the node peer ids in the same string as such:
```
streaming {
cluster {
node_id: "a"
peers: ["a, b, c"]
}
}
```
The correct definition of `peers` should be:
```
peers: ["a", "b", "c"]
```
The server will now list the cluster known peers on startup and
will print a warning if a comma is detected in a peer name:
```
[INF] STREAM: peer 1: "a,b,c"
[WRN] STREAM: Peer name contains ',' make sure you provided an array of peer names, not a string with commas
```
Resolves #990
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The clustering peers list is supposed to contain the list of peer
node ids. However, it happens that users make the mistake of listing
the node peer ids in the same string as such:
The correct definition of
peersshould be:The server will now list the cluster known peers on startup and
will print a warning if a comma is detected in a peer name:
Resolves #990
Signed-off-by: Ivan Kozlovic ivan@synadia.com