Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADDED] Authentication fields in streaming configuration block #1100

Merged
merged 2 commits into from
Oct 8, 2020

Conversation

kozlovic
Copy link
Member

@kozlovic kozlovic commented Oct 8, 2020

Abiltity to provide Username, Password or Token in the streaming
configuration block.

If the configuration is:

authorization {
  users [
    { user: foo, password: bar}
  ]
}
streaming {
  ..
}

the server would fail to start unless user passes -user foo -pass bar
from the command line. But there was no way to pass those from the
configuration file. You can now configure this way:

streaming {
  ..
  username: "foo"
  password: "bar"
}

in order for the server to be able to start without the additional
-user and -pass command line parameters.

Also adding the token configuration option.

Signed-off-by: Ivan Kozlovic ivan@synadia.com

Abiltity to provide Username, Password or Token in the streaming
configuration block.

If the configuration is:
```
authorization {
  users [
    { user: foo, password: bar}
  ]
}
streaming {
  ..
}
```
the server would fail to start unless user passes `-user foo -pass bar`
from the command line. But there was no way to pass those from the
configuration file. You can now configure this way:

```
streaming {
  ..
  username: "foo"
  password: "bar"
}
```
in order for the server to be able to start without the additional
`-user` and `-pass` command line parameters.

Also adding the `token` configuration option.

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 91.717% when pulling 113066d on auth_config_file into e4cd72f on master.

Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kozlovic kozlovic merged commit f785c72 into master Oct 8, 2020
@kozlovic kozlovic deleted the auth_config_file branch October 8, 2020 15:23
kozlovic added a commit to nats-io/nats.docs that referenced this pull request Oct 8, 2020
Document the new configuration fields: username, password, token and nkey_seed_file.
Relates to:
nats-io/nats-streaming-server#1100
nats-io/nats-streaming-server#1101

and will be available in the new Streaming release (v0.19.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants