[IMPROVED] Clustering: queue redelivery to different members #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until now, queue redeliveries in cluster mode behaved differently than in standalone/FT mode. That is, messages delivered to a queue member were always redelivered to that same member. This could be a problem if the application hosting the queue member had an issue where it would not acknowledge messages but at the same time was still running. The leader would always redeliver those same unacknowledged messages to that same misbehaving client. With this change, the queue redelivery is now the same regardless of the streaming server running mode. Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
|
Thanks to @mihai-tiriplica-f3 for verifying that this change works well and solves issues when an application uses a queue subscription but for some reason does not acknowledge the messages. With this change, at least those messages will be redelivered to other healthy members at one point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, queue redeliveries in cluster mode behaved differently
than in standalone/FT mode. That is, messages delivered to a
queue member were always redelivered to that same member.
This could be a problem if the application hosting the queue
member had an issue where it would not acknowledge messages
but at the same time was still running. The leader would always
redeliver those same unacknowledged messages to that same
misbehaving client. With this change, the queue redelivery is
now the same regardless of the streaming server running mode.
Signed-off-by: Ivan Kozlovic ivan@synadia.com