Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] Log failure to create a channel #1232

Merged
merged 1 commit into from
Jan 19, 2022

Conversation

kozlovic
Copy link
Member

If creation of a channel failed, this error was not always logged.

Signed-off-by: Ivan Kozlovic ivan@synadia.com

If creation of a channel failed, this error was not always logged.

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 91.423% when pulling 36b027d on report_err_on_chan_create_failure into 32f9935 on main.

@kozlovic kozlovic merged commit 6f31e06 into main Jan 19, 2022
@kozlovic kozlovic deleted the report_err_on_chan_create_failure branch January 19, 2022 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants