Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] FileStore: handle possible sequence gap in index files #940

Merged
merged 1 commit into from
Sep 11, 2019

Conversation

kozlovic
Copy link
Member

@kozlovic kozlovic commented Sep 7, 2019

Differentiate error reading from the index file as opposed to
not find a given sequence. Gaps should not exist but if that happens
it would prevent messages from being expired or next messages to
be delivered.

Resolves #928

Signed-off-by: Ivan Kozlovic ivan@synadia.com

Differentiate error reading from the index file as opposed to
not find a given sequence. Gaps should not exist but if that happens
it would prevent messages from being expired or next messages to
be delivered.

Resolves #928

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 92.073% when pulling fc3b208 on handle_fstore_seq_gaps into ed7405a on master.

Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kozlovic kozlovic merged commit a4c3624 into master Sep 11, 2019
@kozlovic kozlovic deleted the handle_fstore_seq_gaps branch September 11, 2019 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error during expiration: wrong sequence, wanted 5665328 got 5665327 | Big raft.log files
3 participants