Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADDED] TLSServerName and TLSSkipVerify options #981

Merged
merged 1 commit into from
Dec 3, 2019
Merged

[ADDED] TLSServerName and TLSSkipVerify options #981

merged 1 commit into from
Dec 3, 2019

Conversation

kozlovic
Copy link
Member

@kozlovic kozlovic commented Dec 2, 2019

Added the configuration parameters

  • "server_name": used to verify the hostname returned in the server
    certificate
  • "insecure" (or "skip_verify"): skips the server's certificate chain
    and host name verification (Insecure!)

Resolves #979
Resolves #980

Signed-off-by: Ivan Kozlovic ivan@synadia.com

@kozlovic
[ADDED] TLSServerName and TLSSkipVerify options
8800e13 
Added the configuration parameters
- "server_name": used to verify the hostname returned in the server
  certificate
- "insecure" (or "skip_verify"): skips the server's certificate chain
  and host name verification (Insecure!)

Resolves #979
Resolves #980

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
@kozlovic kozlovic requested a review from ripienaar December 2, 2019 20:10
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 92.016% when pulling 8800e13 on add_server_name_and_skip_verify into b95714e on master.

ripienaar
ripienaar approved these changes Dec 3, 2019
View reviewed changes
Copy link
Collaborator

@ripienaar ripienaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kozlovic kozlovic merged commit 865fc40 into master Dec 3, 2019
@kozlovic kozlovic deleted the add_server_name_and_skip_verify branch December 3, 2019 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ripienaar ripienaar ripienaar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@kozlovic @coveralls @ripienaar