[ADDED] ObjectStore API in jetstream package #1450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jarema
requested changes
Dec 11, 2023
| objAllMetaPreTmpl = "$O.%s.M.>" // $O.<bucket>.M.> // meta stream subject | ||
| objChunksPreTmpl = "$O.%s.C.%s" // $O.<bucket>.C.<object-nuid> // chunk message subject | ||
| objMetaPreTmpl = "$O.%s.M.%s" // $O.<bucket>.M.<name-encoded> // meta message subject | ||
| objNoPending = "0" |
There was a problem hiding this comment.
It's a "0", so this means "no pending"
| streamsReq := streamsRequest{ | ||
| Subject: fmt.Sprintf(objAllChunksPreTmpl, "*"), | ||
| } | ||
| go func() { |
There was a problem hiding this comment.
We probably should cancel the goroutine in case of ctx.Done.
There was a problem hiding this comment.
In case of context timeout we will get canceled / deadline exceeded error on page, err := l.streamInfos(ctx, streamsReq) in line 1244 (when fetching new page) so I don't think it's necessary to add another guard here.
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
piotrpio
force-pushed
the
add-object-store-to-jetstream-pkg
branch
from
b306903
to
ff8804c
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds ObjectStore API to
jetstreampackage.It is for the most part a port of
object.goandobject_test.goto the new package, without many changes. All object store tests moved fromnatspackage pass in the new package (after adding context and changing structs packages)Notable changes:
jetstreampackagePut()andWatch()methods use the legacy push consumers to prevent permission issues when moving to new APIcontext.Contextextensively in line with the rest of the packageSigned-off-by: Piotr Piotrowski piotr@synadia.com