Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prefix in key value stores #1487

Merged
merged 3 commits into from
Dec 12, 2023
Merged

Conversation

Jarema
Copy link
Member

@Jarema Jarema commented Dec 11, 2023

Fixes #1486

Bug was reported for the new API, but actually it also was present in the old API.

Signed-off-by: Tomasz Pietrek tomasz@nats.io

Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Copy link
Member

@aricart aricart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@piotrpio
Copy link
Collaborator

@Jarema this is for KV only, maybe we should add the same change for object store while at it?

@Jarema Jarema changed the title Fix prefix in key value object stores Fix prefix in key value stores Dec 12, 2023
Copy link
Collaborator

@piotrpio piotrpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll fix object store in seeparate PR.

@piotrpio piotrpio merged commit f8caaf9 into main Dec 12, 2023
2 checks passed
@piotrpio piotrpio deleted the fix-prefix-in-key-value-object-stores branch December 12, 2023 11:03
@piotrpio piotrpio mentioned this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[KV] KeyValueStoreNames() in new API returns stores prefixed by KV_
3 participants