[ADDED] ListKeys method for listing kv keys #1490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
wallyqs
reviewed
Dec 12, 2023
| @@ -67,7 +67,10 @@ type ( | |||
| // WatchAll will invoke the callback for all updates. | |||
| WatchAll(ctx context.Context, opts ...WatchOpt) (KeyWatcher, error) | |||
| // Keys will return all keys. | |||
| // DEPRECATED: Use ListKeys instead to avoid memory issues. | |||
There was a problem hiding this comment.
Keys() could be used to fetch millions of keys all stored in a slice before returning. There should be a way of either paging or iterating over the result (which the new method provides). I could add some details to this comment.
There was a problem hiding this comment.
Have a use case now with > 600k keys.
There was a problem hiding this comment.
ah I see, makes sense to switch to use channels instead
Jarema
approved these changes
Dec 12, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Piotr Piotrowski piotr@synadia.com