Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use errors.Is for err handling, and use skipped bool #1500

Merged
merged 1 commit into from
Jan 11, 2024
Merged

chore: use errors.Is for err handling, and use skipped bool #1500

merged 1 commit into from
Jan 11, 2024

Conversation

sashamelentyev
Copy link
Contributor

No description provided.

@sashamelentyev
chore: use errors.Is for err handling, and use skipped bool
48c9da9 
Signed-off-by: Sasha Melentyev <sasha@m8.ru>
@Jarema Jarema requested a review from piotrpio December 17, 2023 15:29
piotrpio
piotrpio approved these changes Jan 11, 2024
View reviewed changes
Copy link
Collaborator

@piotrpio piotrpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you for the contribution!

@piotrpio piotrpio merged commit 98430ac into nats-io:main Jan 11, 2024
1 check passed
@piotrpio piotrpio mentioned this pull request Jan 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotrpio piotrpio piotrpio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sashamelentyev @piotrpio