Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation commands #1745

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Update installation commands #1745

merged 1 commit into from
Dec 5, 2024

Conversation

alexbozhenko
Copy link
Contributor

@alexbozhenko alexbozhenko commented Dec 3, 2024

  1. The info about pre go modules is not relevant anymore, so drop it.
  2. Extra slashes are not needed before the version suffix, per https://go.dev/ref/mod#go-install. So make it consistent.

Also, not sure if the command to get nats server is needed here at all?

Signed-off-by: Alex Bozhenko alex@synadia.com

@alexbozhenko alexbozhenko requested a review from piotrpio December 3, 2024 19:19
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

coveralls commented Dec 3, 2024

Coverage Status

coverage: 84.873% (-0.07%) from 84.944%
when pulling 8720150 on alexbozhenko-patch-1
into f563c66 on main.

Copy link
Collaborator

@piotrpio piotrpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

1. The info about pre go modules is not relevant anymore, so drop it.
2. Extra slashes are not needed before the version suffix, per https://go.dev/ref/mod#go-install. So make it consistent.

Also, not sure if the command to get nats server is needed here at all?

Signed-off-by: Alex Bozhenko <alex@synadia.com>
@piotrpio piotrpio merged commit 01fafde into main Dec 5, 2024
6 checks passed
@piotrpio piotrpio deleted the alexbozhenko-patch-1 branch December 5, 2024 19:03
piotrpio pushed a commit that referenced this pull request Dec 13, 2024
1. The info about pre go modules is not relevant anymore, so drop it.
2. Extra slashes are not needed before the version suffix, per https://go.dev/ref/mod#go-install. So make it consistent.

Signed-off-by: Alex Bozhenko <alex@synadia.com>
piotrpio pushed a commit that referenced this pull request Dec 13, 2024
1. The info about pre go modules is not relevant anymore, so drop it.
2. Extra slashes are not needed before the version suffix, per https://go.dev/ref/mod#go-install. So make it consistent.

Signed-off-by: Alex Bozhenko <alex@synadia.com>
@piotrpio piotrpio mentioned this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants