-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NatsClient to DI #689
base: main
Are you sure you want to change the base?
Add NatsClient to DI #689
Conversation
This change modifies the default serializer and pending policy, hence it is technically a breaking change.
These changes look good to me. Does it make sense to keep |
@rickdotnet good point. I know I marked this as breaking already (actually not breaking compiler but behaviour) but do you think we'd upset a lot of code bases if we removed the method. hmm maybe obsolete the old one and keep it around for a while whether we introduce a new method or not? |
Safest bet, in my opinion, would be to mark it as obsolete and include a nudge in the right direction, either a new method or a link to docs. |
This change modifies the default serializer and pending policy, hence it is technically a breaking change.
resolves #687