Disallow new lines in HeaderValue::from_str

nats-io · May 25, 2023 · 45b788b · 45b788b
1 parent a37dc9b
commit 45b788b
Showing 1 changed file with 11 additions and 0 deletions.
diff --git a/async-nats/src/header.rs b/async-nats/src/header.rs
@@ -222,6 +222,10 @@ impl FromStr for HeaderValue {
     type Err = ParseError;
 
     fn from_str(s: &str) -> Result<Self, Self::Err> {
+        if s.contains(['\r', '\n']) {
+            return Err(ParseError);
+        }
+
         let mut set = HeaderValue::new();
         set.value.push(s.to_string());
         Ok(set)
@@ -420,4 +424,11 @@ mod tests {
         headers.insert("Second", "SecondValue");
         assert!(!headers.is_empty());
     }
+
+    #[test]
+    fn parse_value() {
+        assert!("Foo\r".parse::<HeaderValue>().is_err());
+        assert!("Foo\n".parse::<HeaderValue>().is_err());
+        assert!("Foo\r\n".parse::<HeaderValue>().is_err());
+    }
 }