Do asynchronous DNS lookups in ServerAddr::socket_addrs

nats-io · Jan 6, 2024 · 8c783e0 · 8c783e0
1 parent 0424068
commit 8c783e0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/async-nats/src/connector.rs b/async-nats/src/connector.rs
@@ -152,6 +152,7 @@ impl Connector {
 
             let socket_addrs = server_addr
                 .socket_addrs()
+                .await
                 .map_err(|err| ConnectError::with_source(crate::ConnectErrorKind::Dns, err))?;
             for socket_addr in socket_addrs {
                 match self

diff --git a/async-nats/src/lib.rs b/async-nats/src/lib.rs
@@ -202,7 +202,7 @@ use std::fmt::Display;
 use std::future::Future;
 use std::iter;
 use std::mem;
-use std::net::{SocketAddr, ToSocketAddrs};
+use std::net::SocketAddr;
 use std::option;
 use std::pin::Pin;
 use std::slice;
@@ -1427,8 +1427,8 @@ impl ServerAddr {
     }
 
     /// Return the sockets from resolving the server address.
-    pub fn socket_addrs(&self) -> io::Result<impl Iterator<Item = SocketAddr>> {
-        (self.host(), self.port()).to_socket_addrs()
+    pub async fn socket_addrs(&self) -> io::Result<impl Iterator<Item = SocketAddr> + '_> {
+        tokio::net::lookup_host((self.host(), self.port())).await
     }
 }