Use Duration in a few more places
#1038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah right. I forgot the default serializer implementation is useless, and serde_nanos doesn't support |
Did add support for Option a while ago, but we've been adding things as we need them so might've missed something, which case is failing? |
|
Ah I didn't realize how the API worked. I assumed it was like how |
caspervonb
approved these changes
Jul 26, 2023
|
@paolobarbolini Judging by commits in the PR, I guess some gremlin sneaked while rebasing the branch ;). |
paolobarbolini
force-pushed
the
consumer-more-duration
branch
from
6a6b63f
to
6d3a34c
Compare
|
Fixed |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1037