Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize GETting and object's payload #1040

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Optimize GETting and object's payload #1040

merged 1 commit into from
Jul 25, 2023

Conversation

paolobarbolini
Copy link
Contributor

@paolobarbolini paolobarbolini commented Jul 17, 2023 •
edited
Loading

Removes a memcpy and an allocation from the object read implementation

caspervonb
caspervonb reviewed Jul 18, 2023
View reviewed changes
Copy link
Collaborator

@caspervonb caspervonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was wondering if we could get away with having remaiing_bytes as a BytesMut buffer here.

@paolobarbolini
Copy link
Contributor Author

Was wondering if we could get away with having remaiing_bytes as a BytesMut buffer here.

It could work but if you don't need a Bytes at the end you're just wasting time with the ref-counting and all of the internal bytes machinery

caspervonb
caspervonb approved these changes Jul 20, 2023
View reviewed changes
Copy link
Collaborator

@caspervonb caspervonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Jarema
Jarema approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Jarema Jarema merged commit 68ed49f into nats-io:main Jul 25, 2023
13 checks passed
@Jarema Jarema mentioned this pull request Sep 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caspervonb caspervonb caspervonb approved these changes

@Jarema Jarema Jarema approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paolobarbolini @caspervonb @Jarema