Introduce get and get_all semantics to HeaderMap
#1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caspervonb
force-pushed
the
n1ghtmare/header-map
branch
from
38b8c60
to
c9d029b
Compare
n1ghtmare
force-pushed
the
n1ghtmare/header-map
branch
from
c9d029b
to
d7b1576
Compare
Jarema
reviewed
Aug 4, 2023
| @@ -46,7 +46,7 @@ use serde::{Deserialize, Serialize}; | |||
|
|
|||
| #[derive(Clone, PartialEq, Eq, Debug, Default, Deserialize, Serialize)] | |||
| pub struct HeaderMap { | |||
| inner: HashMap<HeaderName, HeaderValue>, | |||
| inner: HashMap<HeaderName, Vec<HeaderValue>>, | |||
There was a problem hiding this comment.
@caspervonb considering that we are sending 99% cases header with one value, maybe it's worth making this VecOrString enum to save some allocations?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #925