Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jetstream benchmarks #1080

Merged
merged 2 commits into from
Aug 5, 2023
Merged

Add jetstream benchmarks #1080

merged 2 commits into from
Aug 5, 2023

Conversation

Jarema
Copy link
Member

@Jarema Jarema commented Aug 5, 2023

  • adds jetstream publish and publish async benchmarks
  • renames benchmark groups to allow calling specific bench:
cargo bench
cargo bench nats
cargo bench nats::request

Signed-off-by: Tomasz Pietrek tomasz@nats.io

Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
@Jarema Jarema requested a review from caspervonb August 5, 2023 05:39
Copy link
Collaborator

@caspervonb caspervonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (one confusing comment nit)

This was done to allow running a specific bench.
Now `cargo bench nats` or event `cargo bench nats::request` can be used.
While it does fake the module structure, it is really intuitive to use
and prints easy to read benchmark report.

Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
@Jarema Jarema merged commit a59b21e into main Aug 5, 2023
13 checks passed
@Jarema Jarema deleted the add-jetstream-benchmarks branch August 5, 2023 06:53
@Jarema Jarema mentioned this pull request Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants