Fix minimal versions #1108
Merged
Fix minimal versions #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version 0.3.0 incorrectly uses ed25519-dalek.
To reproduce the problem:
cargo +nightly update -Z minimal-versions
cargo check --package async-nats --all-targets
Returned the following:
error[E0599]: no associated item named `BYTE_SIZE` found for struct `ed25519_dalek::Signature` in the current scope
--> /home/nepalez/.cargo/registry/src/index.crates.io-6f17d22bba15001f/nkeys-0.3.0/src/lib.rs:257:58
|
257 | let mut fixedsig = [0; ed25519_dalek::Signature::BYTE_SIZE];
| ^^^^^^^^^ associated item not found in `Signature`
error[E0599]: no function or associated item named `from_bytes` found for struct `ed25519_dalek::Signature` in the current scope
--> /home/nepalez/.cargo/registry/src/index.crates.io-6f17d22bba15001f/nkeys-0.3.0/src/lib.rs:259:47
|
259 | let insig = ed25519_dalek::Signature::from_bytes(&fixedsig)?;
| ^^^^^^^^^^ function or associated item not found in `Signature`
|
= help: items from traits can only be used if the trait is in scope
In the crate tokio-rustls-0.24.0 the dependency
from the crate rustls is too loose (0.21.0).
To reproduce the problem:
cargo +nightly update -Z minimal-versions
cargo check --package async-nats --all-targets
which fails with errors:
error[E0599]: no method named `add_trust_anchors` found for struct `RootCertStore` in the current scope
--> async-nats/src/tls.rs:108:28
|
108 | root_store.add_trust_anchors(trust_anchors);
| ^^^^^^^^^^^^^^^^^ help: there is a method with a similar name: `add_server_trust_anchors`
error[E0599]: no method named `with_client_auth_cert` found for struct `ConfigBuilder` in the current scope
--> async-nats/src/tls.rs:117:29
|
117 | builder.with_client_auth_cert(cert, key).map_err(|_| {
| ^^^^^^^^^^^^^^^^^^^^^ help: there is a method with a similar name: `with_no_client_auth`
The first error evades after updating rustls to 0.21.5,
the second one requires 0.21.6.
nepalez
force-pushed
the
fix-minimal-versions
branch
from
7f156dd
to
2a22c2f
Compare
Jarema
approved these changes
Sep 18, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I checked and then fixed minimal versions for transitive dependencies of the
async-nats.After the fixes it got green.
See detailed explanations in the commit messages