Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix sync TLS authentication for EC keys #1128

Merged
merged 2 commits into from
Nov 3, 2023
Merged

chore: fix sync TLS authentication for EC keys #1128

merged 2 commits into from
Nov 3, 2023

Conversation

sp-angel
Copy link
Contributor

@sp-angel sp-angel commented Oct 6, 2023

Fixes issue #1126

@sp-angel sp-angel mentioned this pull request Oct 6, 2023
Closed
@caspervonb caspervonb self-requested a review October 6, 2023 17:05
@sp-angel
Copy link
Contributor Author

sp-angel commented Oct 6, 2023

Test failing with stable/ubuntu that cropped up seems related to latest 1.73.0.

Can change the code to pass, but that's not related to this change.

@Jarema
Copy link
Member

Jarema commented Oct 6, 2023

Thanks for the PR!

Will be green after #113 is merged.

@Jarema Jarema force-pushed the fix/sync_tls_ec branch 2 times, most recently from cff490f to 8d49b81 Compare October 8, 2023 04:58
@sp-angel
Copy link
Contributor Author

Nice, seems all tests passed now 😄

@sp-angel
Copy link
Contributor Author

hey, I'd love to get this merged. Is there anything pending I could help?

robjtede
robjtede approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@robjtede robjtede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jarema Bump +1. We'd like to have this change please.

Jarema
Jarema approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for your contribution!

@Jarema Jarema merged commit 27ad14a into nats-io:main Nov 3, 2023
10 checks passed
@Jarema Jarema mentioned this pull request Nov 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robjtede robjtede robjtede approved these changes

@Jarema Jarema Jarema approved these changes

@caspervonb caspervonb Awaiting requested review from caspervonb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sp-angel @Jarema @robjtede