Serialize/Deserialize Subject and HeaderName as strings #1168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subjects need to be valid UTF-8, so this is much nicer than a raw byte array when using formats like JSON.
oscarwcl
force-pushed
the
useful-serde
branch
from
8d83eb0
to
1a452a9
Compare
This is much more convenient, and is also required to implement Object Store object headers, since they are serialized to JSON.
oscarwcl
force-pushed
the
useful-serde
branch
from
1a452a9
to
ee931d0
Compare
caspervonb
approved these changes
Dec 1, 2023
Jarema
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default derives produce a very ugly serialization format for these wrappers. Since they are guaranteed to be strings it makes sense to serialize/deserialize them directly as strings.
This also makes it possible to implement Object Store object headers, since they need to deserialize a HeaderMap from JSON.