Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminate fetch on No Messages #1171

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Terminate fetch on No Messages #1171

merged 1 commit into from
Dec 4, 2023

Conversation

Jarema
Copy link
Member

@Jarema Jarema commented Dec 3, 2023

fixes #1169

Signed-off-by: Tomasz Pietrek tomasz@nats.io

@Jarema Jarema requested a review from piotrpio December 3, 2023 21:12
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Copy link
Contributor

@piotrpio piotrpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Jarema Jarema merged commit f43460d into main Dec 4, 2023
11 checks passed
@Jarema Jarema deleted the terminate-on-no-messages branch December 4, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fetch should return None on No messages
2 participants