nats: De/Ser using sample_freq instead of sample_frequency
#1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 21, 2024 13:52
Also adds private module from handling schema differences
Jarema
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addendum to #1300 for the
natsmodule.This PR instructs serde to rename
sample_frequencyintosample_freqduring de/serialization.It also introduces a module for converting the
u8into aString.Finally, this PR adds a test in
nats/tests/jetstream.rsthat can be executed viacargo test -- jetstream_consumer_configs_sample_frequency, which checks that the stored config of the consumer now contains the correctly set field.Removing the
rename = sample_freqdirective from theConsumerConfigtype causes this test to fail, so all seems to be correct.