Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flapping ack test #842

Merged
merged 1 commit into from
Feb 22, 2023
Merged

Fix flapping ack test #842

merged 1 commit into from
Feb 22, 2023

Conversation

Jarema
Copy link
Member

@Jarema Jarema commented Feb 22, 2023

This test started to flap after changes to publish ack and making it async.

@Jarema
Fix flapping ack test
efa550d 
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
piotrpio
piotrpio approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@piotrpio piotrpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - some other test seems to be flapping (on windows), but that seems unrelated.

caspervonb
caspervonb approved these changes Feb 22, 2023
View reviewed changes
Copy link
Collaborator

@caspervonb caspervonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Jarema Jarema merged commit 9d04586 into main Feb 22, 2023
@Jarema Jarema deleted the jarema/fix-flapping-ack-test branch February 22, 2023 21:46
@Jarema Jarema mentioned this pull request Mar 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caspervonb caspervonb caspervonb approved these changes

@piotrpio piotrpio piotrpio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jarema @caspervonb @piotrpio