Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retaining server list order option & Fix reconnect burst on auth failure #890

Merged
merged 2 commits into from
Mar 22, 2023

Conversation

Jarema
Copy link
Member

@Jarema Jarema commented Mar 22, 2023

Signed-off-by: Tomasz Pietrek tomasz@nats.io

@Jarema Jarema requested a review from caspervonb March 22, 2023 12:53
@Jarema Jarema force-pushed the jarema/add-retaining-server-order branch from 76d68d8 to fa1baef Compare March 22, 2023 12:53
Copy link
Collaborator

@caspervonb caspervonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits and bike shedding

async-nats/src/connector.rs Outdated Show resolved Hide resolved
async-nats/src/options.rs Show resolved Hide resolved
@Jarema Jarema force-pushed the jarema/add-retaining-server-order branch from fa1baef to d0f60da Compare March 22, 2023 13:01
@Jarema Jarema requested a review from caspervonb March 22, 2023 13:01
@Jarema Jarema force-pushed the jarema/add-retaining-server-order branch 3 times, most recently from 3fc33ac to 47cfd4b Compare March 22, 2023 13:14
Copy link
Collaborator

@caspervonb caspervonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but does two things, consider splitting for changelog.

@Jarema Jarema force-pushed the jarema/add-retaining-server-order branch from 47cfd4b to 7e5e9a3 Compare March 22, 2023 14:35
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
@Jarema Jarema force-pushed the jarema/add-retaining-server-order branch from 7e5e9a3 to 77ad1e4 Compare March 22, 2023 14:35
@Jarema Jarema merged commit 3d92ce2 into main Mar 22, 2023
@Jarema Jarema deleted the jarema/add-retaining-server-order branch March 22, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants