async_nats: pull: Use u64 instead of usize for nanoseconds #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, thats a good catch, though PR is not paasing tests, as it need a little more work. |
usize is too small in 32-bit environments, especially since it is initialized with 30 seconds, i.e. 30_000_000_000 nanoseconds which is already bigger than 2**32.
|
The linter was complaining about casts that are now unnecessary. Should be fixed now. |
Jarema
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
usize is too small in 32-bit environments, especially since it is initialized with 30 seconds, i.e. 30_000_000_000 nanoseconds which is already bigger than 2**32.