Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow new lines in HeaderValue::from_str #943

Merged
merged 2 commits into from
May 26, 2023

Conversation

caspervonb
Copy link
Collaborator

@caspervonb caspervonb commented Apr 29, 2023

Closes #942

@caspervonb caspervonb requested a review from Jarema April 29, 2023 10:48
Copy link
Collaborator

@n1ghtmare n1ghtmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caspervonb caspervonb force-pushed the validate-header-values branch 2 times, most recently from f32772f to ece5eff Compare May 8, 2023 14:36
@caspervonb caspervonb force-pushed the validate-header-values branch 6 times, most recently from d4fed02 to 09cda6e Compare May 25, 2023 14:30
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idea is ok, but test fails for a valid reason ;)

Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@caspervonb caspervonb merged commit 7f8cf8e into nats-io:main May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate HeaderValue for correctness and parity
3 participants