Progress bar on nats object put|get work inverted

[rickardgranberg]

Was doing some testing of the Object Store feature and didn't understand why I didn't see the progress bars.

I ran: nats object put <bucket> <file> and nats object put --progress <bucket> <file> expecting to see a progress bar but did not. And yes, my file was over 20480 bytes.

To my surprise, running nats object put --no-progress <bucket> <file> makes the progress bar appear!

I've traced it to the lines

natscli/cli/object_command.go

Line 85 in 1057211

put.Flag("progress", "Disables progress bars").Default("true").BoolVar(&c.noProgress)

natscli/cli/object_command.go

Line 97 in 1057211

get.Flag("progress", "Disables progress bars").Default("true").BoolVar(&c.noProgress)

The flag is named --progress with a default of true but the variable it's assigned to is named noProgress and it's used in that capacity on line

natscli/cli/object_command.go

Line 486 in 1057211

if !opts.Trace && !c.noProgress && stat != nil && stat.Size() > 20480 {

and

natscli/cli/object_command.go

Line 562 in 1057211

if !opts.Trace && !c.noProgress && nfo.Size > 20480 {

I'll be happy to provide a PR with a fix, but I'm a little uncertain if the intention was to have progress enabled or disabled by default.

[ripienaar]

hmmm, yeah i think logic is just reversed, should be always on

[rickardgranberg]

Alright. I'll work on a fix