Fix progress bars not working #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ripienaar
reviewed
Sep 30, 2022
cli/object_command.go
Outdated
| @@ -82,7 +82,7 @@ NOTE: This is an experimental feature. | |||
| put.Flag("name", "Override the name supplied to the object store").StringVar(&c.overrideName) | |||
| put.Flag("description", "Sets an optional description for the object").StringVar(&c.description) | |||
| put.Flag("header", "Adds headers to the object").Short('H').StringsVar(&c.hdrs) | |||
| put.Flag("progress", "Disables progress bars").Default("true").BoolVar(&c.noProgress) | |||
| put.Flag("no-progress", "Disable progress bars").UnNegatableBoolVar(&c.noProgress) | |||
There was a problem hiding this comment.
since the new cli library now have negatable booleans I think I'd rather like:
put.Flag("progress", "Disable progress bars").Default("true").BoolVar(&c.progress)
like in stream backup and restore, its a bit more in tune also with how we handle other boolean flags now
There was a problem hiding this comment.
OK. Update coming!
|
nice one thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a suggested fix for issue #593
I decided to rename the flag to
--no-progressto match the one in thebenchcommand