Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Honor sub count limits for raw/dump #495

Merged
merged 1 commit into from
Jun 10, 2022
Merged

Honor sub count limits for raw/dump #495

merged 1 commit into from
Jun 10, 2022

Commits on Jun 9, 2022

  1. Honor sub count limits for raw/dump 

    "Chris" on nats slack reported that `nats sub $subject --count $N` did not work
with `--raw`; analysis of code exposed that this also does not work with
`--raw`.

Adjust the control flow in the registered handler function to treat the
pretty-case as another branch, before final clean-up; I rejected the "duplicate
the limit check in two other places" approach as not scaling if more work needs
to be done on each branch.
    @philpennock
    philpennock committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    2fe2ee3 View commit details
    Browse the repository at this point in the history