Add the ability to ls keys of a bucket #531
Conversation
cli/kv_command.go
Outdated
| ls.Flag("names", "Show just the bucket names").Short('n').UnNegatableBoolVar(&c.listNames) | ||
| ls.Flag("verbose", "Show detailed info about the key").Short('v').BoolVar(&c.lsVerbose) |
There was a problem hiding this comment.
can also be UnNegatableBoolVar, same with --display-value
There was a problem hiding this comment.
Sure thing. Will do.
cli/kv_command.go
Outdated
| func (c *kvCommand) lsBucketKeys(mgr *jsm.Manager) error { | ||
| if mgr == nil { | ||
| return errors.New("mgr cannot be nil") | ||
| } |
There was a problem hiding this comment.
as this is only used internall and we know how we call it, and mgr setup failure already handled elsewhere I think this check can go - error would anyway not help users.
And actually mgr isnt used here at all so remove the argument I think, we can then move the call to create the mgr into lsBuckets as thats the only place its used
cli/kv_command.go
Outdated
| keys, err := kv.Keys() | ||
| if err != nil { | ||
| if err == nats.ErrNoKeysFound { | ||
| return fmt.Errorf("no keys found in bucket %s", c.bucket) |
There was a problem hiding this comment.
I dont think this is an error condition, see for example how we handle no streams, we just print a message and clean exit
Line 2416 in 7b15a8d
There was a problem hiding this comment.
Sounds good. Will update.
dselans
force-pushed
the
dselans/list_bucket_contents
branch
from
2ccbdce to
9a2b381
Compare
|
@ripienaar addressed your comments. |
cli/kv_command.go
Outdated
| keys, err := kv.Keys() | ||
| if err != nil { | ||
| if err == nats.ErrNoKeysFound { | ||
| fmt.Printf("No keys found in bucket") |
There was a problem hiding this comment.
Bah! Sorry about that! Fixed.
|
Thank you |
Needed the ability to easily list the keys in a bucket.
Probably doing something against convention - let me know if anything needs to be fixed up.
Thanks!
EDIT: Attached screenshot of what it looks like.
