Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quote StoreDir and reuse new escape filter #736

Merged
merged 1 commit into from
Mar 20, 2023
Merged

quote StoreDir and reuse new escape filter #736

merged 1 commit into from
Mar 20, 2023

Conversation

kmpm
Copy link
Contributor

@kmpm kmpm commented Mar 17, 2023

As a follow up to #732

  • Reuse the new escape filter for .StoreDir instead of separate fix.
  • Quote store_dir value

@kmpm kmpm force-pushed the fix/escape_more branch from acf5024 to 6c7e4b4 Compare March 17, 2023 13:31
@ripienaar
Copy link
Collaborator

Perfect, is it possible for you to gpg sign the commit?

@kmpm
Copy link
Contributor Author

kmpm commented Mar 20, 2023

Will sign shortly.

@kmpm
Copy link
Contributor Author

kmpm commented Mar 20, 2023

Signed, if SSH signing is enough.

@ripienaar
Copy link
Collaborator

Should be enough you just need to upload your pubkey to GitHub so it can verify

@kmpm
Copy link
Contributor Author

kmpm commented Mar 20, 2023

It is now, and the check on the pr cleared

@ripienaar
Copy link
Collaborator

Weird, maybe some caching issue at github, anyway will merge as is. Thanks a lot!

@ripienaar ripienaar merged commit e6d2b3a into nats-io:main Mar 20, 2023
@kmpm kmpm deleted the fix/escape_more branch March 20, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kmpm @ripienaar