add revision to kv get trace output #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ripienaar
reviewed
Apr 28, 2023
cli/kv_command.go
Outdated
| @@ -492,7 +492,7 @@ func (c *kvCommand) getAction(_ *fisk.ParseContext) error { | |||
| return nil | |||
| } | |||
|
|
|||
| fmt.Printf("%s > %s created @ %s\n", res.Bucket(), res.Key(), res.Created().Format(time.RFC822)) | |||
| fmt.Printf("%s > %s seq %d created @ %s\n", res.Bucket(), res.Key(), res.Revision(), res.Created().Format(time.RFC822)) | |||
There was a problem hiding this comment.
lets call it revision: %d instead, revision is the word people using the APIs would recognise.
maxarndt
force-pushed
the
add-seqno-to-kv-get-trace
branch
from
8362f63 to
1601020
Compare
maxarndt
changed the title
rename seq to revision in trace output
maxarndt
force-pushed
the
add-seqno-to-kv-get-trace
branch
from
1601020 to
c5f9a53
Compare
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the sequence number of a message to the output of
nats kv get <bucket> <key> --traceThe timestamp of the message was already present but I missed the sequence number.
I'm aware that the history command shows this information but for me this is the right place as well for this information.