Include msgsin msgsout fields #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just be noted that the PR in the NATS Streaming server is not yet merged. |
renanberto
changed the title
|
I have merged PR (nats-io/nats-streaming-server#976) in the Streaming server. Note that the PR adds the in/out msgs (count) but also bytes. However this PR deals only with the count. For completeness, I wonder if we should include bytes too? |
I think it's worth Ivan, I'll add these fields to the collect. |
renanberto
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys.
This change is intended to include the new streaming-server API metrics
msgs_inandmsgs_out.Thanks!
[Warning] this metric is only collected after this nats-streaming-server commit : nats-io/nats-streaming-server@b95714e