read.neurons warns about about missing files

* closes #386
natverse · Feb 6, 2019 · f4af0b1 · f4af0b1
1 parent 46cd754
commit f4af0b1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/R/neuron-io.R b/R/neuron-io.R
@@ -203,7 +203,7 @@ read.neurons<-function(paths, pattern=NULL, neuronnames=NULL, format=NULL,
 
   if(!is.character(paths)) stop("Expects a character vector of filenames")
 
-  if(length(paths)==1 && file.info(paths)$isdir)
+  if(length(paths)==1 && isTRUE(file.info(paths)$isdir))
     paths=dir(paths,pattern=pattern,full.names=TRUE)
 
   if(is.function(neuronnames))

diff --git a/tests/testthat/test-neuron-io.R b/tests/testthat/test-neuron-io.R
@@ -144,6 +144,11 @@ test_that("we can read in neurons as a neuronlist",{
                  regexp = 'While reading file.*Neurites\\.am')
 })
 
+test_that('we can deal with bad input to read.neurons', {
+  # by definition tempfile() doesn't exist
+  expect_warning(read.neurons(tempfile()), regexp = "No such file or directory")
+})
+
 test_that("we can read hxlineset format neurons",{
 
   ebt7=structure(list(NeuronName = "EBT7R", InputFileName = "testdata/neuron/EBT7R.am",